Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed listing blocks for backend/s3 #567

Merged
merged 1 commit into from
Mar 4, 2021
Merged

fixed listing blocks for backend/s3 #567

merged 1 commit into from
Mar 4, 2021

Conversation

jojand
Copy link
Contributor

@jojand jojand commented Mar 4, 2021 •
edited
Loading

What this PR does:
This PR fixes tempodb/backend/s3/Blocks() to fetch the complete list of blocks in case the ListObjects() result is truncated.

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@CLAassistant
Copy link

CLAassistant commented Mar 4, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jojand jojand marked this pull request as draft March 4, 2021 10:14
annanay25
annanay25 reviewed Mar 4, 2021
View reviewed changes
Copy link
Contributor

@annanay25 annanay25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! This looks good to me. Is there a reason its marked Draft?

@jojand jojand marked this pull request as ready for review March 4, 2021 11:31
@jojand
Copy link
Contributor Author

jojand commented Mar 4, 2021

Neat! This looks good to me. Is there a reason its marked Draft?

Thanks for the fast reply! I was just polishing it a bit.

@jojand jojand requested a review from annanay25 March 4, 2021 11:33
@mdisibio mdisibio merged commit 1cbfc21 into grafana:master Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdisibio mdisibio mdisibio approved these changes

@dgzlopes dgzlopes Awaiting requested review from dgzlopes

@joe-elliott joe-elliott Awaiting requested review from joe-elliott

@annanay25 annanay25 Awaiting requested review from annanay25

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jojand @CLAassistant @annanay25 @mdisibio